Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add directly single tags to nvti. #385

Merged
merged 3 commits into from
Sep 9, 2019
Merged

Add directly single tags to nvti. #385

merged 3 commits into from
Sep 9, 2019

Conversation

janowagner
Copy link
Member

This removes knowledge about internal representation of tag sequence from openvas.
It should be the job of the nvti module to handle it on its own.

This requires greenbone/gvm-libs#263

jjnicola
jjnicola requested changes Sep 9, 2019
View reviewed changes
Copy link
Member

@jjnicola jjnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Just the CHANGELOG.md update is missing.

@janowagner janowagner requested a review from jjnicola September 9, 2019 10:04
@jjnicola jjnicola merged commit b39f550 into greenbone:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjnicola jjnicola jjnicola approved these changes

@ArnoStiefvater ArnoStiefvater Awaiting requested review from ArnoStiefvater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janowagner @jjnicola