Fix mis-identification of Sphinx Search service #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was detected as MySQL in nasl_builtin_find_service.c
cfi-gb
reviewed
Sep 9, 2019
to make this regex a little bit more strict and to avoid false detection.
cfi-gb
suggested changes
Sep 10, 2019
Also, remove some parentheses which make part of the pattern optional, because it allowed to match other undesirable strings/words.
cfi-gb
suggested changes
Sep 11, 2019
Internally the function replace Null char with 'x'
cfi-gb
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was detected as MySQL in nasl_builtin_find_service.c