Prevent deadlock, ensure that no locks are being held at the time of forking #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnicola
force-pushed
the
log-mutex-lock
branch
from
095a7d5 to
b914e14
Compare
|
Depends on PR greenbone/gvm-libs#328 |
jjnicola
force-pushed
the
log-mutex-lock
branch
2 times, most recently
from
82e94b6 to
bf6f5e6
Compare
…forking. During testing, the child deadlock was reproduce, directly after fork, when logging the message "Testing xxx.xxx.xxx.xxx (Vhost...." Since alive detection is running in a thread, it can lock a mutex when the main process is forking a new child. This mutex is copied into the child process in its locked state, and any child that tries to lock the mutex waits forever. This patch prevent the child deadlock.
Also, set the defaul log level to 16 (warning).
jjnicola
requested review from
mattmundell and
ArnoStiefvater
and removed request for
ArnoStiefvater
ArnoStiefvater
approved these changes
May 4, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing, the child deadlock was reproduce, right after fork()'ing, when logging the message
"Testing xxx.xxx.xxx.xxx (Vhost...."
Before, since alive detection is running in a thread, it can lock a mutex when the main process is forking a new child. This mutex is copied into the child process in its locked state, and any child that tries to lock the mutex waits forever.
Also, add log domain for alive detection.