Fix calculation of cell size in get_tcp_element() #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnicola
previously approved these changes
Jul 10, 2020
cfi-gb
reviewed
Jul 10, 2020
ArnoStiefvater
force-pushed
the
get-tcp-element-wrong-cell-size
branch
from
da38cde to
f99b9d7
Compare
Th_off is only one byte and should not be converted with ntohl() which takes 4 bytes.
ArnoStiefvater
force-pushed
the
get-tcp-element-wrong-cell-size
branch
from
f99b9d7 to
3e1a3db
Compare
cfi-gb
suggested changes
Jul 20, 2020
Data of size 0 was considered as error. Now it is allowed.
cfi-gb
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.