Check if another forked child has already added the vhost. #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnicola
force-pushed
the
vhosts
branch
3 times, most recently
from
4ee5412 to
6f94084
Compare
jjnicola
changed the title
jjnicola
changed the title
cfi-gb
reviewed
Aug 19, 2020
cfi-gb
reviewed
Aug 20, 2020
There was a problem hiding this comment.
Tested for regressions of this change with some larger scans. No additional problems found, scans are still working as expected.
I wasn't able to reproduce the initial problem though and can't judge on the code changes itself, a final approval is required by @greenbone/gvm-dev
In some cases, in which expand_vhosts and test_empty_vhost options are enabled, a plugin process fork()s one child for vhost. These children inherit the current state of vhosts list, but it does not check if the concurrent child plugin has already added a new found vhost. Now, it checks not only if the vhost has been added by another plugin before (and already exists in the vhosts list), but also checks if a concurrent child added to the internal/vhosts key in redis.
Like the previous commit, but this check is done at host process level, It does not removes the appended vhosts from internal/vhosts key (get instead pop) So, avoids race condition in which other plugins checks for adding the same vhosts, and they have an outdated vhosts list.
ArnoStiefvater
approved these changes
Aug 20, 2020
|
Backport to the openvas-7.0 branch in #584 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, in which expand_vhosts and test_empty_vhost options
are enabled, a plugin process fork()s one child for vhost.
These children inherit the current state of vhosts list, but it does not
check if the concurrent child plugin has already added a new found vhost.
Now, it checks not only if the vhost has been added by another plugin before
(and already exists in the vhosts list), but also checks if a concurrent child
added to the internal/vhosts key in redis.