Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gcc-9 adn gcc-10 warnings #655

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Feb 11, 2021

What:
Add the '\0' after the strncpy call.
For one case, despite the '\0' char is added after strncpy, the compiler raises a warning.
Therefore strncpy is replace with memcpy.

Why:
Fix gcc-9 adn gcc-10 warnings

How:

Checklist:

Add the nul char after the strncpy call.
For one case the, despite the nul char is added after strncpy, the compiler raises a warning.
Therefore strncpy is replace with memcpy.
@jjnicola jjnicola mentioned this pull request Feb 11, 2021
@jjnicola
Copy link
Member Author

Fix for #651

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bjoernricks bjoernricks merged commit 0044172 into greenbone:openvas-20.08 Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants