Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log message for WMI connect failed or missing WMI support. #670

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Mar 4, 2021

What:
Both, a WMI connect failed or the WMI stub function return NULL.
The message suggest that the connect failed can be produce because
missing WMI support.

Why:
To let now the user that the libopenvas_wmiclient is missing. See openvas-smb

How:
Build the scanner from scratch, but remove/rename the openvas-smb libs, so you don't have WMI support. Run a scan and check the log.

Checklist:

@jjnicola jjnicola requested a review from a team as a code owner March 4, 2021 07:37
@jjnicola jjnicola changed the base branch from master to openvas-20.08 March 4, 2021 07:37
@jjnicola jjnicola requested a review from ArnoStiefvater as a code owner March 4, 2021 07:37
@jjnicola jjnicola requested a review from cfi-gb March 4, 2021 08:25
cfi-gb
cfi-gb previously approved these changes Mar 4, 2021
Copy link
Member

@cfi-gb cfi-gb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

The message suggest that the connect failed can be produce because
missing WMI support.
@ArnoStiefvater ArnoStiefvater merged commit 113176b into greenbone:openvas-20.08 Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants