Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code improvements #700

Merged
merged 4 commits into from
Apr 14, 2021
Merged

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Apr 8, 2021

What:

  1. Set host end_time first and then set the host finished.
  2. Log a message if the scanner did not launched all plugins against a host.
  3. Do not call pluginlaunch_stop() twice.

Why:

  1. this is the order which ospd-openvas expects the status.
  2. To know if not all plugins were launched against the host.
  3. Therefore.

How:

Checklist:

@jjnicola jjnicola requested a review from ArnoStiefvater as a code owner April 8, 2021 12:57
@ArnoStiefvater ArnoStiefvater merged commit 0fab236 into greenbone:openvas-20.08 Apr 14, 2021
ArnoStiefvater added a commit that referenced this pull request Apr 14, 2021
ArnoStiefvater added a commit that referenced this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants