Fix SIGSEGV when no best route is found. #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some case there is no a best route, and no source route can be assigned. This fix set source with the address in the first route found in the route table or 0.0.0.0 in case an empty route table.
ArnoStiefvater
approved these changes
Apr 16, 2021
This was referenced Apr 16, 2021
jjnicola
added a commit
that referenced
this pull request
Apr 16, 2021
Fix SIGSEGV when no best route is found. (backport #702)
jjnicola
added a commit
that referenced
this pull request
Apr 16, 2021
Fix SIGSEGV when no best route is found. (backport #702)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix SIGSEGV when no best route is found.
Why:
In some case there is no a best route, and no source route can be assigned.
This fix set source with the address in the first route found in the route table
or 0.0.0.0 in case an empty route table.
There is no issue with IPv6, since there is no IPv6 broadcast address.
How:
Set veth in a new namespace and run the following script (which sends to broadcast address).
Without the patch, the command above SIGSEGVs
Checklist: