[master] Refactor sending of dead host status #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnicola
requested changes
Jul 21, 2021
src/attack.c
Outdated
| * @return 0 on success, -1 on failure. | ||
| */ | ||
| static int | ||
| comm_send_status_host_dead (kb_t main_kb, char *hostname) |
There was a problem hiding this comment.
I would use ip_str instead of hostname, since we are using the IP. Also, this change would fix the typo in the docstring.
Suggested change
| comm_send_status_host_dead (kb_t main_kb, char *hostname) | |
| comm_send_status_host_dead (kb_t main_kb, char *ip_str) |
src/attack.c
Outdated
| * for implicit singalling that the host ist dead. | ||
| * | ||
| * @param main_kb Kb to use | ||
| * @param hostnae ip_str representation of host |
There was a problem hiding this comment.
use ip_str.
Suggested change
| * @param hostnae ip_str representation of host | |
| * @param ip_str ip_str representation of host |
src/attack.c
Outdated
| @@ -511,10 +558,7 @@ attack_host (struct scan_globals *globals, struct in6_addr *ip, GSList *vhosts, | |||
| "<description/><type/><name/></source></detail></host>", | |||
| ip_str); | |||
| #if (PROGRESS_BAR_STYLE == 1) | |||
There was a problem hiding this comment.
I think we can remove this preprocessor directive. It is always set to 1 and other modules does not hanlde other option than this for dead hosts.. The DEFINE is above in the same file.
Separate sending of progress status and sending of this special status case.
ArnoStiefvater
force-pushed
the
improve-host-dead-status
branch
from
7815440 to
b14e678
Compare
jjnicola
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Refactor sending of dead host status. Its only a first small improvement. This will be improved more in the future.
Why:
Separate sending of progress status and sending of
this special status case.
How:
Checklist: