Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Do small refactor #810

Merged
merged 2 commits into from
Aug 2, 2021

Conversation

ArnoStiefvater
Copy link
Member

@ArnoStiefvater ArnoStiefvater commented Aug 2, 2021

What:

Remove reload_openvas.
Rename load_scan_preferences().
Rename variable file_hash to file_uuid.
Delete scanner_thread() and rename start_single_task_scan().
Refactor update_vt_info().
Handle sentry open and close in openvas() only.
Remove undocumented functionality similar to update_vt_info at the end of openvas().
Add better function documentation.

Why:

Clean up.
SC-333

How:

Checklist:

Remove reload_openvas.
Rename load_scan_preferences().
Rename variable file_hash to file_uuid.
Delete scanner_thread() and rename start_single_task_scan().
Refactor update_vt_info().
Handle sentry open and close in openvas() only.
Remove undocumented functionality similar to update_vt_info at the end of openvas().
Add better function documentation.
@ArnoStiefvater ArnoStiefvater requested a review from a team as a code owner August 2, 2021 05:38
@ArnoStiefvater ArnoStiefvater changed the title Do small refactor [master] Do small refactor Aug 2, 2021
Copy link
Member

@jjnicola jjnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjnicola jjnicola merged commit 4ed6413 into greenbone:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants