Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 5.5: PHP Strict Standards: Only variables should be passed by reference #93

Open
vojta opened this issue Oct 10, 2014 · 2 comments
Open

PHP 5.5: PHP Strict Standards: Only variables should be passed by reference #93

vojta opened this issue Oct 10, 2014 · 2 comments
Labels
enhancement Shard-Query

Comments

@vojta
Copy link

vojta commented Oct 10, 2014

PHP Strict Standards: Only variables should be passed by reference in /home/users/klarka/wc/2/libs/shard-query/include/shard-query.php on line 2115.

What about some refactoring to support strict PHP 5.5 + a coding standard? http://www.php-fig.org/psr/psr-2/

I think we could help you with that refactoring.
@greenlion
Copy link
Owner

I would be okay refactoring for strict PHP 5.5, but I'm unsure how many people still have CentOS boxes with PHP 5.3 on them. I've tried to stay 5.3 compatible up until now.

@vojta
Copy link
Author

vojta commented Oct 13, 2014

OK, I get your point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Shard-Query
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vojta @greenlion