Extracted duplicated download_format_links methods into helper #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This serves two purposes. The first is to remove the duplicated code, and the second is to stop using a hard coded list of default formats. With this change, plugins can specify additional download formats so long as the Mime type is registered.
|
Looks good to me. I wonder why Travis did not run this PR... |
pcreux
added a commit
that referenced
this pull request
Nov 2, 2012
Extracted duplicated download_format_links methods into helper
|
@pcreux Cheers mate. Travis PR issues should be resolved now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This serves two purposes. The first is to remove the duplicated code,
and the second is to stop using a hard coded list of default formats.
With this change, plugins can specify additional download formats so
long as the Mime type is registered.
Once this has been merged, I will release a gem that can be used to add xlsx downloads for collections.