Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing deprecated bourbon box-shadow mixin #1913

Merged
merged 1 commit into from
Mar 4, 2013

Conversation

stereoscott
Copy link
Contributor

As of Bourbon 3.1.0, the box-shadow mixin is deprecated.

@kibenimatik
Copy link

👍

@seanlinsley
Copy link
Contributor

So... does it still operate the same way? What did the mixin provide that direct-setting the box-shadow attr didn't?

@stereoscott
Copy link
Contributor Author

Yeah, the vendor prefixes for box-shadow are only required in old versions of Firefox which amount to 0.77% of market share (who knows how accurate that really is..). Here is the discussion within Bourbon:
EDIT: thoughtbot/bourbon#156
(issue on active_admin: #1912)

Either way, if active_admin is dependent on bourbon, it should at the very least set a version number so that upgrades to Bourbon do not break active_admin.

@seanlinsley
Copy link
Contributor

Thank you for saving me the time from having to look that up myself :]

Looks good. ✅

@macfanatic
Copy link
Contributor

Thanks for this, will hunt down other issues that are related to the same problem & close.

macfanatic added a commit that referenced this pull request Mar 4, 2013
Removing deprecated bourbon box-shadow mixin
@macfanatic macfanatic merged commit 3d98a2a into activeadmin:master Mar 4, 2013
arturtr referenced this pull request Dec 4, 2013
thanks to @chrise86 for the updated CSS so this isn't horribly ugly
@arturtr
Copy link
Contributor

arturtr commented Dec 4, 2013

This commit 41a6b1f is opened this issue

Fix please

@arturtr
Copy link
Contributor

arturtr commented Dec 4, 2013

I made patch for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants