[1093] HABTM Select Filters #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is now fully working. Thoughts @macfanatic? |
This was referenced May 6, 2013
| if method.present? && options[:as] ||= default_input_type(method) | ||
| form_buffers.last << input(method, options) | ||
| else | ||
| '' |
There was a problem hiding this comment.
Why doesn't this empty string get appended to the form_buffers array?
There was a problem hiding this comment.
I have no idea; that's just how the original code was implemented.
There was a problem hiding this comment.
Ultimately what it's doing is calling our FormBuilder version of input:
def input(method, *args)
content = with_new_form_buffer{ super }
@inputs_with_block ? form_buffers.last << content : content
endSo the code in question should be simplified to be this instead:
def filter(method, options = {})
if method.present? && options[:as] ||= default_input_type(method)
input(method, options)
end
end
|
@daxter - Other than my 1 question, looks good to me. |
|
As it happens, 70d1df0 implements the things I described in #2123 💃 |
|
The logs on Travis are completely unreadable... Guess I'll have to build a Rails 3.0 test app and run everything locally. |
Assuming Foo HABTM Bars, the below now works as you'd expect: ```ruby ActiveAdmin.register Foo do filter :bars end ```
+ `filter :attr, as: :select` now plucks DB values by default + properly add default polymorphic filters + move common Formtastic overrides into a single module
seanlinsley
added a commit
that referenced
this pull request
May 24, 2013
[1093] HABTM Select Filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1093
filter :attr, as: :selectnow utilizesActiveRecord#pluckwhen using Rails >= 3.2 (resolves Better defaults for filters #2123)