Adds the ability to use starts_with and ends_with in string filters #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filter :title_starts_with, :as => :string filter :title_ends_with, :as => :string activeadmin#1958
| @@ -15,7 +15,11 @@ def label_text | |||
| end | |||
|
|
|||
| def input_name | |||
| "#{super}_contains" | |||
| method.to_s.match(metasearch_conditions) ? method: "#{method}_contains" | |||
There was a problem hiding this comment.
Looks like you're missing a space in that ternary operator.
There was a problem hiding this comment.
Strange that the tests didn't break ... but it's been fixed.
There was a problem hiding this comment.
Probably for the same reason that this works:
irb(main):001:0> true ? foo: 5
NameError: undefined local variable or method `foo' for main:ObjectAs in, the ternary operator has higher precedence in the Ruby parser.
macfanatic
added a commit
that referenced
this pull request
Mar 7, 2013
|
Hmm, looks like issue didn't close automatically, but this was pulled in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filter :title_starts_with, :as => :string
filter :title_ends_with, :as => :string
Fixes #1958