Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2110 fix header styles #2125

Merged
merged 1 commit into from
Apr 19, 2013

Conversation

ball-hayden
Copy link
Contributor

Some work on correcting the styling as per issue #2110

Screenshot from 2013-04-19 16:18:50

@seanlinsley
Copy link
Contributor

Could you attach a screenshot of how your changes look in the most common scenario, like I did in #2110? As in, what it looks like with only a couple menu items.

@ball-hayden
Copy link
Contributor Author

Certainly.

Screenshot from 2013-04-19 17:25:18

@seanlinsley
Copy link
Contributor

Looks like there's too much space between the Logout link and the right edge of the page. Could be wrong.

Otherwise, this looks great. Thanks for taking the time to do this 💜

@ball-hayden
Copy link
Contributor Author

Does that look better?

Screenshot from 2013-04-19 17:44:07

@seanlinsley
Copy link
Contributor

I'm fine with it as long as it's the same distance as what we have on the left side of the page.

@ball-hayden
Copy link
Contributor Author

The original was the same excluding padding on the logout button. After 45d9d6e it is now the same including padding on the logout button.

i.e (as of 45d9d6e).
The title is padded 30px from the left.
The utilities section is padded 26px from the right, and the logout button 4px from the right.

@seanlinsley
Copy link
Contributor

:]

Just tried this out locally, and looks great. If you can squash these commits I'll merge in your changes.

@seanlinsley seanlinsley mentioned this pull request Apr 19, 2013
@ball-hayden
Copy link
Contributor Author

Apologies for the delay.

seanlinsley added a commit that referenced this pull request Apr 19, 2013
@seanlinsley seanlinsley merged commit 5af134d into activeadmin:master Apr 19, 2013
@seanlinsley
Copy link
Contributor

Merged. Thanks again!

@ball-hayden ball-hayden deleted the 2110-fix-header-styles branch April 19, 2013 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants