Remove Railtie, Use Rails Engine #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActiveAdmin had both a Railtie and an Engine. This commit consolidates this duplication to use engines, and moves locale files to their conventional location for an Engine. This commit is a step towards resolving activeadmin#2126.
|
👍 |
|
Are there any known side effects to this? |
|
None that I know of. An Engine is merely a Railtie with some built in configuration, this just makes ActiveAdmin adhere to that configuration. |
|
Or for that matter, I'm curious if any AA bugs have been caused by us having both a Railtie and an Engine. |
|
I'll whip up a sample app and test it tonight on Heroku. |
|
Works like a charm!. Use the usual credentials. If someone changes them by the time you get to this, let me know. |
|
Okay, looks good. Merging! 🐙 |
seanlinsley
added a commit
that referenced
this pull request
May 4, 2013
Remove Railtie, Use Rails Engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveAdmin had both a Railtie and an Engine. This commit consolidates
this duplication to use engines, and moves locale files to their
conventional location for an Engine.
This commit is a step towards resolving #2126.