Fix i18n for boolean filter (updates the fix for #2170) #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to commit 47fe4c5 but fixes regression that caused untranslated labels for boolean filters.
|
Okay, thanks for squashing the commits. For future reference, if you used interactive git rebase you would have been able to update #2206 instead of opening a new pull request. |
seanlinsley
added a commit
that referenced
this pull request
May 22, 2013
Fix i18n for boolean filter (updates the fix for #2170)
|
Thanks for the contribution! 💙 |
|
Oh I see, I actually used |
|
Yeah you can do this to force history rewrite on GitHub: git push --force origin your_branch_name # -f is the short version of --force |
|
Awesome! Much cleaner. Thanks 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as PR #2206 but squashes commits into a single commit. Updates 47fe4c5 that initially fixed #2170 but introduced a regression.