Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update string filter UI #2228

Merged
merged 1 commit into from
May 27, 2013
Merged

update string filter UI #2228

merged 1 commit into from
May 27, 2013

Conversation

seanlinsley
Copy link
Contributor

  • removes "Search %{field}" translations since as of 2002 sql like operate on text field #2096 you get to choose the search method
  • updates string filter UI so the method select is side-by-side with the input field
  • moves related JS out of the HTML

Before

string_filter_before

After

string_filter_after

@seanlinsley
update string filter UI
2417845 
+ removes "Search %{field}" translations since you now get to choose the search method
+ updates string filter UI so the method select is side-by-side with the input field
+ moves related JS out of the HTML
@seanlinsley
Copy link
Contributor Author

/cc @joseluistorres, @macfanatic, @pcreux

@seanlinsley seanlinsley mentioned this pull request May 26, 2013
Closed
@joseluistorres
Copy link
Contributor

👍

seanlinsley added a commit that referenced this pull request May 27, 2013
@seanlinsley
Merge pull request #2228 from Daxter/ui/string_filter_side-by-side
d583bfa 
update string filter UI
@seanlinsley seanlinsley merged commit d583bfa into activeadmin:master May 27, 2013
@seanlinsley seanlinsley deleted the ui/string_filter_side-by-side branch May 27, 2013 03:23
@seanlinsley seanlinsley mentioned this pull request Jul 17, 2013
Closed
@seanlinsley seanlinsley mentioned this pull request Jan 31, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanlinsley @joseluistorres