-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Object#to_html. #496
Conversation
+1 Lost an hour on exploring why Kramdown works perfectly well in IRb but not in my Rails app. Thanks for this hint. |
+1 This also conflicts with Rabl. See nesquena/rabl#112 |
+1 Because adding a random method to every single Object in order to make like 2 method calls slightly more convenient may not be the best approach. |
This closes #151. |
+1 Also does not play nicely with escape_utils |
+1 It would be great if this small patch were applied. It seems much cleaner and gets rid of the obnoxious warning messages in the console. |
+1 Would really appreciate this patch. The log warnings in #151 make it impossible to debug anything in my app. |
+1 This is not a behavior i expected when i added the gem. |
+1 |
1 similar comment
+1 |
+1 Extending core classes might be done with extreme caution, but this extension seems unnecessary and the warning are crazy-making. |
+1 |
Yes please |
+1 - it also breaks the ruport gem, which uses to_html for formatting a report as HTML |
+1 for extreme values of 1 |
+1 |
1 similar comment
+1 |
this is sound good @gregbell! Nice commits |
oh, Huzzah! |
I have removed Object#to_html because it conflicts with
kramdown
gem and also there are some issues reported in #151.ActiveAdmin should avoid extending Ruby core classes.