Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Object#to_html. #496

Closed
wants to merge 1 commit into from
Closed

Conversation

ebeigarts
Copy link
Contributor

I have removed Object#to_html because it conflicts with kramdown gem and also there are some issues reported in #151.

ActiveAdmin should avoid extending Ruby core classes.

@dmke
Copy link

dmke commented Sep 21, 2011

+1

Lost an hour on exploring why Kramdown works perfectly well in IRb but not in my Rails app. Thanks for this hint.

@kylefleming
Copy link

+1

This also conflicts with Rabl. See nesquena/rabl#112

@nesquena
Copy link

+1 Because adding a random method to every single Object in order to make like 2 method calls slightly more convenient may not be the best approach.

@pcreux
Copy link
Contributor

pcreux commented Sep 27, 2011

@gregbell will a look at this.

Philippe, @gregbell assistant.

@pcreux
Copy link
Contributor

pcreux commented Sep 27, 2011

This closes #151.

@jarinudom
Copy link

+1

Also does not play nicely with escape_utils

@mattvague
Copy link
Contributor

@gregbell @pcreux have we come to a consensus on this one?

@jolby
Copy link

jolby commented Oct 18, 2011

+1

It would be great if this small patch were applied. It seems much cleaner and gets rid of the obnoxious warning messages in the console.

@dpmccabe
Copy link

+1

Would really appreciate this patch. The log warnings in #151 make it impossible to debug anything in my app.

@turlockmike
Copy link

+1 This is not a behavior i expected when i added the gem.

@jslag
Copy link

jslag commented Nov 11, 2011

+1

1 similar comment
@gmcintire
Copy link

+1

@pcantrell
Copy link

+1 Extending core classes might be done with extreme caution, but this extension seems unnecessary and the warning are crazy-making.

@dukex
Copy link

dukex commented Nov 16, 2011

+1

@jtsagata
Copy link

Yes please

@swalberg
Copy link

+1 - it also breaks the ruport gem, which uses to_html for formatting a report as HTML

@pcantrell
Copy link

+1 for extreme values of 1

@hoverlover
Copy link
Contributor

+1

1 similar comment
@outsmartin
Copy link

+1

@gregbell
Copy link
Contributor

gregbell commented Jan 9, 2012

Hi guys, Sorry this one took me so long to get to. I merged it into master and removed any references in Arbre to to_html.

Relevant commits: 67e27b9 and 43bc2a8

@gregbell gregbell closed this Jan 9, 2012
@dukex
Copy link

dukex commented Jan 9, 2012

this is sound good @gregbell! Nice commits

@unflores
Copy link

unflores commented Feb 1, 2012

oh, Huzzah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.