-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formtastic 2.0 support #527
Conversation
AWESOME! I'll definitely be using your fork until this is accepted by @gregbell |
would love to see this pulled in. |
Hi @ebeigarts. Thanks for your work! I haven't gotten a chance to go through the code yet, but I hope to get this merged in this week. We may have to support both version of formtastic for while to make it easier for users to upgrade. |
Thanks you bro! |
@ebeigarts Thank you! |
@ebeigarts Kudos to you! |
Awesome work, you deserve many cupcakes! |
Very excited about this addition! |
It seems like Formtastic 2 is a drop in replacement for v1. Does anyone have any objections to setting Formtastic 2 to as dependency? Obviously this means any application using Active Admin needs to upgrade to Formtastic 2. Anyone have any upgrade stories to share? @mattvague - Was the upgrade seamless at VersaPay (minus Active Admin)? |
Would it be hard to keep implementations for Formastic 1 & 2 (at least φ |
@pcreux it would require moving at least 2 methods from formtastic 1.2 to active admin, see #499 (comment) |
@gregbell There weren't too many problems that I recall when I tried to do the upgrade aside from a couple name changes in formtastic.rb and changing a few monkey patches (and of course AA). I'm in favour of setting 2.0 as a dependency. I'd rather force people to upgrade to 2.0 to than prevent them from upgrading to it. If worse comes to worst people can always lock to an older version of ActiveAdmin if they can't upgrade Formtastic for some reason. |
I'm waiting for this patch... I need formtastic 2, and i dont want to install active_admin as plugin for my new project :( |
Great job, great job! |
Also waiting for the FT 2.0 patch... I need the "member_label" option for my checkbox inputs :D |
Agreed! |
Thanks! Hope it gets pulled in soon ^^ |
Is there any news on the ETA for this? A lot of people would be grateful, including myself. :) |
+1, it will also fix a bug when using active_admin and client_side_validations in the same app: #607 |
Thanks! Great job! I really need this update. |
Please use @ebeigarts fork until @gregbell get a chance to review & merge this pull request. |
This is going to be merged in. We're going to release it as 0.4.0 and change the dependency of Active Admin to formtastic ~> 2. I should have a chance to merge it in over the next couple of days. |
Thanks for this update Edgars! I just merged it in. |
Thanks @gregbell!! :) |
Thank you very much! I think a lot of people will be more than happy with these updates! |
Thanks! |
thanks! |
Currently it is still not available within gemcutter :( |
Just wondering if there are any plans to release with support for Formtastic 2 anytime soon? I'm not able to use other gems because active_admin is holding me back! |
@jmaskell just use the git version of Active Admin :) |
I have refactored all the input helers to use the new Formtastic 2.0 custom input convention and the code looks much cleaner now.
This is not compatible with Formtastic 1.2, since there have been a lot of changes between 1.2 and 2.0.
I can confirm that all specs and cucucmber features are passing and it is already working in one of my applications.