Fix scope i18n for 'all' scope #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any comments or alternative approaches to solving this? |
|
Maybe instead of inlining "all" we could implement an i18n_key method on Scope that returns the proper key given the current method? |
|
I can merge it in and then move it there after. |
gregbell
added a commit
that referenced
this pull request
Oct 21, 2011
Fix scope i18n for 'all' scope
gregbell
added a commit
that referenced
this pull request
Oct 21, 2011
I18n keys we're being generated using Scope#scope_method which can be nil sometimes. To fix this, we moved to #scope_method || 'all'. Instead of this approach we can reliably use #id, which will always return a sane key.
parndt
pushed a commit
to resolve/active_admin
that referenced
this pull request
Jun 13, 2012
I18n keys we're being generated using Scope#scope_method which can be nil sometimes. To fix this, we moved to #scope_method || 'all'. Instead of this approach we can reliably use #id, which will always return a sane key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using active_admin's i18n for scopes and the 'all' scope is included on a resource, scope.scope_method is nil and so the i18n scope resolves to '.active_admin.scopes', which outputs the hash of all keys under this i18n key.
The fix falls back to the key active_admin.scopes.all, if the scope_method is not set.
See also this post on the mailing list from another user, that describes the problem and ways to reproduce:
http://groups.google.com/group/activeadmin/browse_thread/thread/3e52dd49c3669d4d