Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active_admin assets to precompile list in engine #822

Merged
merged 2 commits into from
Feb 19, 2012
Merged

Add active_admin assets to precompile list in engine #822

merged 2 commits into from
Feb 19, 2012

Conversation

jschwindt
Copy link
Contributor

This pull request solves the problem of adding active_admin assets in the application. What is does is configuring the engine to add them to the precompile list so the application using ActiveAdmin does not need to do it.

Related issue: #483

@pcreux
Copy link
Contributor

pcreux commented Jan 30, 2012

This is great, and will help a lot of people deploying their active admin app!

Could you make sure that it would work when using Rails 3.0.0?

@jschwindt
Copy link
Contributor Author

Hi, Philippe.

I've just updated the pull request to ensure that it doesn't affect Rails version 3.0.x.

Juan.

@pcreux
Copy link
Contributor

pcreux commented Feb 19, 2012

Cool, thanks!

@ghost ghost assigned pcreux Feb 19, 2012
pcreux added a commit that referenced this pull request Feb 19, 2012
Add active_admin assets to precompile list in engine
@pcreux pcreux merged commit cb028f0 into activeadmin:master Feb 19, 2012
@tsongas
Copy link

tsongas commented Mar 13, 2013

I'm a Rails newbie using ActiveAdmin for the first time, unfortunately this fix didn't keep me from having to add the following to application.rb in order for my site to run on Heroku (after pulling some hair out I might add):
config.assets.precompile += ['active_admin.css', 'active_admin.js', 'active_admin/print.css']
Not sure if I'm doing something wrong elsewhere....

@exviva
Copy link
Contributor

exviva commented Mar 13, 2013

@tsongas this was fixed by #1910, but still not released, so you'd need to use the master branch.

@seanlinsley
Copy link
Contributor

@tsongas which you can do by putting this in your Gemfile:

gem 'activeadmin', github: 'gregbell/active_admin'

@akshayrawat
Copy link

This is released in 0.6.0. Issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants