Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is there a way to get a ref of an SVG? #28

Closed
lifeiscontent opened this issue Dec 9, 2017 · 3 comments
Closed

is there a way to get a ref of an SVG? #28

lifeiscontent opened this issue Dec 9, 2017 · 3 comments

Comments

@lifeiscontent
Copy link
Contributor

lifeiscontent commented Dec 9, 2017

As the title says, is it possible currently? Or would this be a feature we can add?

if you're willing to add this feature, I'd sugged calling it svgRef as the prop to hook

@gregberge
Copy link
Owner

gregberge commented Dec 9, 2017

I think it is a good idea. In fact it is just a template, we could add a config option and handle it in both templates (React and React Native).

If you want to submit a PR, here are the steps:

And of course add some tests 😅.

Thanks!

@lifeiscontent
Copy link
Contributor Author

@neoziro where can I find docs on h2x stuff?

@gregberge
Copy link
Owner

@lifeiscontent there is a separated repository for h2x. The architecture is pretty similar to Babel one. By reading this babel handbook you should be able to understand it better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants