Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(svgo): support any SVGO config format #412

Merged
merged 1 commit into from
Mar 22, 2020
Merged

Conversation

gregberge
Copy link
Owner

Fixes #400

Summary

Test plan

@vercel
Copy link

vercel bot commented Mar 22, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/gregberge/svgr/hg52j1v98
✅ Preview: https://svgr-git-fix-svgo-config.gregberge.now.sh

@codecov
Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #412 into master will decrease coverage by 0.57%.
The diff coverage is 78.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
- Coverage   85.55%   84.98%   -0.58%     
==========================================
  Files          30       31       +1     
  Lines         526      526              
  Branches      143      145       +2     
==========================================
- Hits          450      447       -3     
- Misses         63       64       +1     
- Partials       13       15       +2     
Impacted Files Coverage Δ
packages/plugin-svgo/src/config.js 76.19% <76.19%> (ø)
packages/plugin-svgo/src/index.js 66.66% <100.00%> (-7.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 853db4e...90b471c. Read the comment docs.

@kuoruan
Copy link
Contributor

kuoruan commented Apr 23, 2020

@gregberge Missing .svgorc.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't set SVGO options
2 participants