Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url with protocol prefixed with emoji being incorrectly parsed #399

Closed
caiofct opened this issue Jan 25, 2023 · 3 comments
Closed

Url with protocol prefixed with emoji being incorrectly parsed #399

caiofct opened this issue Jan 25, 2023 · 3 comments

Comments

@caiofct
Copy link

caiofct commented Jan 25, 2023

An url like 👍https://www.google.com is being parsed as http://oogle.com/ . If I remove the protocol and just use
👍www.google.com then it will be parsed correctly http://xn--www-0113b.google.com/.

This can be confirmed using the live demo example: http://greg-jacobs.com/Autolinker.js/examples/live-example/

I believe this could be a regression from #276.

@caiofct
Copy link
Author

caiofct commented Jan 30, 2023

@gregjacobs Any chance you could take a look at this one?

@gregjacobs
Copy link
Owner

This is now fixed in 4.0.1. Thanks for reporting!

@caiofct
Copy link
Author

caiofct commented Jan 6, 2025

Hey @gregjacobs I just tried the fixed version 4.0.1 of this library and the reported issue here is still happening. You can see it in the demo page:

👍https://www.google.com => Doesn't work
👍www.google.com => Works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants