net/mlx5: HWS, Fix memory leak in hws_action_get_shared_stc_nic error flow

lkayal-01 · gregkh · commit 051fd8576a2e · 2025-09-04T16:55:40.000+02:00
[ Upstream commit a630f83 ] When an invalid stc_type is provided, the function allocates memory for shared_stc but jumps to unlock_and_out without freeing it, causing a memory leak. Fix by jumping to free_shared_stc label instead to ensure proper cleanup. Fixes: 504e536 ("net/mlx5: HWS, added actions handling") Signed-off-by: Lama Kayal <lkayal@nvidia.com> Reviewed-by: Tariq Toukan <tariqt@nvidia.com> Signed-off-by: Mark Bloch <mbloch@nvidia.com> Link: https://patch.msgid.link/20250825143435.598584-3-mbloch@nvidia.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/action.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/action.c
@@ -117,7 +117,7 @@ static int hws_action_get_shared_stc_nic(struct mlx5hws_context *ctx,
 		mlx5hws_err(ctx, "No such stc_type: %d\n", stc_type);
 		pr_warn("HWS: Invalid stc_type: %d\n", stc_type);
 		ret = -EINVAL;
-		goto unlock_and_out;
+		goto free_shared_stc;
 	}
 
 	ret = mlx5hws_action_alloc_single_stc(ctx, &stc_attr, tbl_type,

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ static int hws_action_get_shared_stc_nic(struct mlx5hws_context *ctx,`
`117`	`117`	`mlx5hws_err(ctx, "No such stc_type: %d\n", stc_type);`
`118`	`118`	`pr_warn("HWS: Invalid stc_type: %d\n", stc_type);`
`119`	`119`	`ret = -EINVAL;`
`120`		`- goto unlock_and_out;`
	`120`	`+ goto free_shared_stc;`
`121`	`121`	`}`
`122`	`122`
`123`	`123`	`ret = mlx5hws_action_alloc_single_stc(ctx, &stc_attr, tbl_type,`