Skip to content

Commit 0b3725d

Browse files
pvVudentz
authored andcommitted
Bluetooth: hci_event: fix MTU for BN == 0 in CIS Established
BN == 0x00 in CIS Established means no isochronous data for the corresponding direction (Core v6.1 pp. 2394). In this case SDU MTU should be 0. However, the specification does not say the Max_PDU_C_To_P or P_To_C are then zero. Intel AX210 in Framed CIS mode sets nonzero Max_PDU for direction with zero BN. This causes failure later when we try to LE Setup ISO Data Path for disabled direction, which is disallowed (Core v6.1 pp. 2750). Fix by setting SDU MTU to 0 if BN == 0. Fixes: 2be22f1 ("Bluetooth: hci_event: Fix parsing of CIS Established Event") Signed-off-by: Pauli Virtanen <pav@iki.fi> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
1 parent 4d19cd2 commit 0b3725d

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

net/bluetooth/hci_event.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6745,8 +6745,8 @@ static void hci_le_cis_established_evt(struct hci_dev *hdev, void *data,
67456745
qos->ucast.out.latency =
67466746
DIV_ROUND_CLOSEST(get_unaligned_le24(ev->p_latency),
67476747
1000);
6748-
qos->ucast.in.sdu = le16_to_cpu(ev->c_mtu);
6749-
qos->ucast.out.sdu = le16_to_cpu(ev->p_mtu);
6748+
qos->ucast.in.sdu = ev->c_bn ? le16_to_cpu(ev->c_mtu) : 0;
6749+
qos->ucast.out.sdu = ev->p_bn ? le16_to_cpu(ev->p_mtu) : 0;
67506750
qos->ucast.in.phy = ev->c_phy;
67516751
qos->ucast.out.phy = ev->p_phy;
67526752
break;
@@ -6760,8 +6760,8 @@ static void hci_le_cis_established_evt(struct hci_dev *hdev, void *data,
67606760
qos->ucast.in.latency =
67616761
DIV_ROUND_CLOSEST(get_unaligned_le24(ev->p_latency),
67626762
1000);
6763-
qos->ucast.out.sdu = le16_to_cpu(ev->c_mtu);
6764-
qos->ucast.in.sdu = le16_to_cpu(ev->p_mtu);
6763+
qos->ucast.out.sdu = ev->c_bn ? le16_to_cpu(ev->c_mtu) : 0;
6764+
qos->ucast.in.sdu = ev->p_bn ? le16_to_cpu(ev->p_mtu) : 0;
67656765
qos->ucast.out.phy = ev->c_phy;
67666766
qos->ucast.in.phy = ev->p_phy;
67676767
break;

0 commit comments

Comments
 (0)