Skip to content

Commit 0d6f4cb

Browse files
ttabigregkh
authored andcommitted
drm/nouveau: remove unused increment in gm200_flcn_pio_imem_wr
[ Upstream commit f529b89 ] The 'tag' parameter is passed by value and is not actually used after being incremented, so remove the increment. It's the function that calls gm200_flcn_pio_imem_wr that is supposed to (and does) increment 'tag'. Fixes: 0e44c21 ("drm/nouveau/flcn: new code to load+boot simple HS FWs (VPR scrubber)") Reviewed-by: Philipp Stanner <phasta@kernel.org> Signed-off-by: Timur Tabi <ttabi@nvidia.com> Link: https://lore.kernel.org/r/20250813001004.2986092-2-ttabi@nvidia.com Signed-off-by: Danilo Krummrich <dakr@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 3ab9f5a commit 0d6f4cb

File tree

1 file changed

+1
-1
lines changed
  • drivers/gpu/drm/nouveau/nvkm/falcon

1 file changed

+1
-1
lines changed

drivers/gpu/drm/nouveau/nvkm/falcon/gm200.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ gm200_flcn_pio_imem_wr_init(struct nvkm_falcon *falcon, u8 port, bool sec, u32 i
103103
static void
104104
gm200_flcn_pio_imem_wr(struct nvkm_falcon *falcon, u8 port, const u8 *img, int len, u16 tag)
105105
{
106-
nvkm_falcon_wr32(falcon, 0x188 + (port * 0x10), tag++);
106+
nvkm_falcon_wr32(falcon, 0x188 + (port * 0x10), tag);
107107
while (len >= 4) {
108108
nvkm_falcon_wr32(falcon, 0x184 + (port * 0x10), *(u32 *)img);
109109
img += 4;

0 commit comments

Comments
 (0)