Skip to content

Commit 33cf70b

Browse files
committed
drm/i915/lnl+/tc: Fix max lane count HW readout
On LNL+ for a disconnected sink the pin assignment value gets cleared by the HW/FW as soon as the sink gets disconnected, even if the PHY ownership got acquired already by the BIOS/driver (and hence the PHY itself is still connected and used by the display). During HW readout this can result in detecting the PHY's max lane count as 0 - matching the above cleared aka NONE pin assignment HW state. For a connected PHY the driver in general (outside of intel_tc.c) expects the max lane count value to be valid for the video mode enabled on the corresponding output (1, 2 or 4). Ensure this by setting the max lane count to 4 in this case. Note, that it doesn't matter if this lane count happened to be more than the max lane count with which the PHY got connected and enabled, since the only thing the driver can do with such an output - where the DP-alt sink is disconnected - is to disable the output. v2: Rebased on change reading out the pin configuration only if the PHY is connected. Cc: stable@vger.kernel.org # v6.8+ Reported-by: Charlton Lin <charlton.lin@intel.com> Tested-by: Khaled Almahallawy <khaled.almahallawy@intel.com> Reviewed-by: Mika Kahola <mika.kahola@intel.com> Signed-off-by: Imre Deak <imre.deak@intel.com> Link: https://lore.kernel.org/r/20250811080152.906216-4-imre.deak@intel.com
1 parent 3e32438 commit 33cf70b

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

drivers/gpu/drm/i915/display/intel_tc.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include "intel_modeset_lock.h"
2424
#include "intel_tc.h"
2525

26+
#define DP_PIN_ASSIGNMENT_NONE 0x0
2627
#define DP_PIN_ASSIGNMENT_C 0x3
2728
#define DP_PIN_ASSIGNMENT_D 0x4
2829
#define DP_PIN_ASSIGNMENT_E 0x5
@@ -308,6 +309,8 @@ static int lnl_tc_port_get_max_lane_count(struct intel_digital_port *dig_port)
308309
REG_FIELD_GET(TCSS_DDI_STATUS_PIN_ASSIGNMENT_MASK, val);
309310

310311
switch (pin_assignment) {
312+
case DP_PIN_ASSIGNMENT_NONE:
313+
return 0;
311314
default:
312315
MISSING_CASE(pin_assignment);
313316
fallthrough;
@@ -1159,6 +1162,12 @@ static void xelpdp_tc_phy_get_hw_state(struct intel_tc_port *tc)
11591162
tc->lock_wakeref = tc_cold_block(tc);
11601163

11611164
read_pin_configuration(tc);
1165+
/*
1166+
* Set a valid lane count value for a DP-alt sink which got
1167+
* disconnected. The driver can only disable the output on this PHY.
1168+
*/
1169+
if (tc->max_lane_count == 0)
1170+
tc->max_lane_count = 4;
11621171
}
11631172

11641173
drm_WARN_ON(display->drm,

0 commit comments

Comments
 (0)