Skip to content

Commit 82e7451

Browse files
Ayushi Makhijagregkh
authored andcommitted
drm/msm: update the high bitfield of certain DSI registers
[ Upstream commit 494045c ] Currently, the high bitfield of certain DSI registers do not align with the configuration of the SWI registers description. This can lead to wrong programming these DSI registers, for example for 4k resloution where H_TOTAL is taking 13 bits but software is programming only 12 bits because of the incorrect bitmask for H_TOTAL bitfeild, this is causing DSI FIFO errors. To resolve this issue, increase the high bitfield of the DSI registers from 12 bits to 16 bits in dsi.xml to match the SWI register configuration. Signed-off-by: Ayushi Makhija <quic_amakhija@quicinc.com> Fixes: 4f52f5e ("drm/msm: import XML display registers database") Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Patchwork: https://patchwork.freedesktop.org/patch/666229/ Link: https://lore.kernel.org/r/20250730123938.1038640-1-quic_amakhija@quicinc.com Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent d7c5df5 commit 82e7451

File tree

1 file changed

+14
-14
lines changed
  • drivers/gpu/drm/msm/registers/display

1 file changed

+14
-14
lines changed

drivers/gpu/drm/msm/registers/display/dsi.xml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -159,28 +159,28 @@ xsi:schemaLocation="https://gitlab.freedesktop.org/freedreno/ rules-fd.xsd">
159159
<bitfield name="RGB_SWAP" low="12" high="14" type="dsi_rgb_swap"/>
160160
</reg32>
161161
<reg32 offset="0x00020" name="ACTIVE_H">
162-
<bitfield name="START" low="0" high="11" type="uint"/>
163-
<bitfield name="END" low="16" high="27" type="uint"/>
162+
<bitfield name="START" low="0" high="15" type="uint"/>
163+
<bitfield name="END" low="16" high="31" type="uint"/>
164164
</reg32>
165165
<reg32 offset="0x00024" name="ACTIVE_V">
166-
<bitfield name="START" low="0" high="11" type="uint"/>
167-
<bitfield name="END" low="16" high="27" type="uint"/>
166+
<bitfield name="START" low="0" high="15" type="uint"/>
167+
<bitfield name="END" low="16" high="31" type="uint"/>
168168
</reg32>
169169
<reg32 offset="0x00028" name="TOTAL">
170-
<bitfield name="H_TOTAL" low="0" high="11" type="uint"/>
171-
<bitfield name="V_TOTAL" low="16" high="27" type="uint"/>
170+
<bitfield name="H_TOTAL" low="0" high="15" type="uint"/>
171+
<bitfield name="V_TOTAL" low="16" high="31" type="uint"/>
172172
</reg32>
173173
<reg32 offset="0x0002c" name="ACTIVE_HSYNC">
174-
<bitfield name="START" low="0" high="11" type="uint"/>
175-
<bitfield name="END" low="16" high="27" type="uint"/>
174+
<bitfield name="START" low="0" high="15" type="uint"/>
175+
<bitfield name="END" low="16" high="31" type="uint"/>
176176
</reg32>
177177
<reg32 offset="0x00030" name="ACTIVE_VSYNC_HPOS">
178-
<bitfield name="START" low="0" high="11" type="uint"/>
179-
<bitfield name="END" low="16" high="27" type="uint"/>
178+
<bitfield name="START" low="0" high="15" type="uint"/>
179+
<bitfield name="END" low="16" high="31" type="uint"/>
180180
</reg32>
181181
<reg32 offset="0x00034" name="ACTIVE_VSYNC_VPOS">
182-
<bitfield name="START" low="0" high="11" type="uint"/>
183-
<bitfield name="END" low="16" high="27" type="uint"/>
182+
<bitfield name="START" low="0" high="15" type="uint"/>
183+
<bitfield name="END" low="16" high="31" type="uint"/>
184184
</reg32>
185185

186186
<reg32 offset="0x00038" name="CMD_DMA_CTRL">
@@ -209,8 +209,8 @@ xsi:schemaLocation="https://gitlab.freedesktop.org/freedreno/ rules-fd.xsd">
209209
<bitfield name="WORD_COUNT" low="16" high="31" type="uint"/>
210210
</reg32>
211211
<reg32 offset="0x00058" name="CMD_MDP_STREAM0_TOTAL">
212-
<bitfield name="H_TOTAL" low="0" high="11" type="uint"/>
213-
<bitfield name="V_TOTAL" low="16" high="27" type="uint"/>
212+
<bitfield name="H_TOTAL" low="0" high="15" type="uint"/>
213+
<bitfield name="V_TOTAL" low="16" high="31" type="uint"/>
214214
</reg32>
215215
<reg32 offset="0x0005c" name="CMD_MDP_STREAM1_CTRL">
216216
<bitfield name="DATA_TYPE" low="0" high="5" type="uint"/>

0 commit comments

Comments
 (0)