Skip to content

Commit 91b2601

Browse files
Li Nangregkh
authored andcommitted
md: prevent incorrect update of resync/recovery offset
[ Upstream commit 7202082 ] In md_do_sync(), when md_sync_action returns ACTION_FROZEN, subsequent call to md_sync_position() will return MaxSector. This causes 'curr_resync' (and later 'recovery_offset') to be set to MaxSector too, which incorrectly signals that recovery/resync has completed, even though disk data has not actually been updated. To fix this issue, skip updating any offset values when the sync action is FROZEN. The same holds true for IDLE. Fixes: 7d9f107 ("md: use new helpers in md_do_sync()") Signed-off-by: Li Nan <linan122@huawei.com> Link: https://lore.kernel.org/linux-raid/20250904073452.3408516-1-linan666@huaweicloud.com Signed-off-by: Yu Kuai <yukuai3@huawei.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent fbd879f commit 91b2601

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

drivers/md/md.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9089,6 +9089,11 @@ void md_do_sync(struct md_thread *thread)
90899089
}
90909090

90919091
action = md_sync_action(mddev);
9092+
if (action == ACTION_FROZEN || action == ACTION_IDLE) {
9093+
set_bit(MD_RECOVERY_INTR, &mddev->recovery);
9094+
goto skip;
9095+
}
9096+
90929097
desc = md_sync_action_name(action);
90939098
mddev->last_sync_action = action;
90949099

0 commit comments

Comments
 (0)