Skip to content

Commit db93635

Browse files
cpackham-atlnzgregkh
authored andcommitted
hwmon: (ina238) Correctly clamp temperature
[ Upstream commit 98fd069 ] ina238_write_temp() was attempting to clamp the user input but was throwing away the result. Ensure that we clamp the value to the appropriate range before it is converted into a register value. Fixes: 0d9f596 ("hwmon: (ina238) Modify the calculation formula to adapt to different chips") Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> Link: https://lore.kernel.org/r/20250829030512.1179998-3-chris.packham@alliedtelesis.co.nz Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 71895f8 commit db93635

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/hwmon/ina238.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,7 @@ static int ina238_write_temp(struct device *dev, u32 attr, long val)
481481
return -EOPNOTSUPP;
482482

483483
/* Signed */
484-
regval = clamp_val(val, -40000, 125000);
484+
val = clamp_val(val, -40000, 125000);
485485
regval = div_s64(val * 10000, data->config->temp_lsb) << data->config->temp_shift;
486486
regval = clamp_val(regval, S16_MIN, S16_MAX) & (0xffff << data->config->temp_shift);
487487

0 commit comments

Comments
 (0)