Skip to content

Commit ff9c072

Browse files
Oreoluwa Babatundegregkh
authored andcommitted
of: reserved_mem: Restructure call site for dma_contiguous_early_fixup()
[ Upstream commit 2c223f7 ] Restructure the call site for dma_contiguous_early_fixup() to where the reserved_mem nodes are being parsed from the DT so that dma_mmu_remap[] is populated before dma_contiguous_remap() is called. Fixes: 8a6e02d ("of: reserved_mem: Restructure how the reserved memory regions are processed") Signed-off-by: Oreoluwa Babatunde <oreoluwa.babatunde@oss.qualcomm.com> Tested-by: William Zhang <william.zhang@broadcom.com> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Link: https://lore.kernel.org/r/20250806172421.2748302-1-oreoluwa.babatunde@oss.qualcomm.com Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 91b3d8e commit ff9c072

File tree

3 files changed

+15
-6
lines changed

3 files changed

+15
-6
lines changed

drivers/of/of_reserved_mem.c

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
#include <linux/memblock.h>
2626
#include <linux/kmemleak.h>
2727
#include <linux/cma.h>
28+
#include <linux/dma-map-ops.h>
2829

2930
#include "of_private.h"
3031

@@ -175,13 +176,17 @@ static int __init __reserved_mem_reserve_reg(unsigned long node,
175176
base = dt_mem_next_cell(dt_root_addr_cells, &prop);
176177
size = dt_mem_next_cell(dt_root_size_cells, &prop);
177178

178-
if (size &&
179-
early_init_dt_reserve_memory(base, size, nomap) == 0)
179+
if (size && early_init_dt_reserve_memory(base, size, nomap) == 0) {
180+
/* Architecture specific contiguous memory fixup. */
181+
if (of_flat_dt_is_compatible(node, "shared-dma-pool") &&
182+
of_get_flat_dt_prop(node, "reusable", NULL))
183+
dma_contiguous_early_fixup(base, size);
180184
pr_debug("Reserved memory: reserved region for node '%s': base %pa, size %lu MiB\n",
181185
uname, &base, (unsigned long)(size / SZ_1M));
182-
else
186+
} else {
183187
pr_err("Reserved memory: failed to reserve memory for node '%s': base %pa, size %lu MiB\n",
184188
uname, &base, (unsigned long)(size / SZ_1M));
189+
}
185190

186191
len -= t_len;
187192
}
@@ -472,7 +477,10 @@ static int __init __reserved_mem_alloc_size(unsigned long node, const char *unam
472477
uname, (unsigned long)(size / SZ_1M));
473478
return -ENOMEM;
474479
}
475-
480+
/* Architecture specific contiguous memory fixup. */
481+
if (of_flat_dt_is_compatible(node, "shared-dma-pool") &&
482+
of_get_flat_dt_prop(node, "reusable", NULL))
483+
dma_contiguous_early_fixup(base, size);
476484
/* Save region in the reserved_mem array */
477485
fdt_reserved_mem_save_node(node, uname, base, size);
478486
return 0;

include/linux/dma-map-ops.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,9 @@ static inline void dma_free_contiguous(struct device *dev, struct page *page,
153153
{
154154
__free_pages(page, get_order(size));
155155
}
156+
static inline void dma_contiguous_early_fixup(phys_addr_t base, unsigned long size)
157+
{
158+
}
156159
#endif /* CONFIG_DMA_CMA*/
157160

158161
#ifdef CONFIG_DMA_DECLARE_COHERENT

kernel/dma/contiguous.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -483,8 +483,6 @@ static int __init rmem_cma_setup(struct reserved_mem *rmem)
483483
pr_err("Reserved memory: unable to setup CMA region\n");
484484
return err;
485485
}
486-
/* Architecture specific contiguous memory fixup. */
487-
dma_contiguous_early_fixup(rmem->base, rmem->size);
488486

489487
if (default_cma)
490488
dma_contiguous_default_area = cma;

0 commit comments

Comments
 (0)