Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for RAW files? #54

Open
lrq3000 opened this issue Sep 11, 2021 · 5 comments
Open

Support for RAW files? #54

lrq3000 opened this issue Sep 11, 2021 · 5 comments

Comments

@lrq3000
Copy link

lrq3000 commented Sep 11, 2021

The app is amazing, but it seems RAW images aren't supported. Is this planned in the future by any chance?

@gregordr
Copy link
Owner

Some raw types are already supported, however as you can see at https://en.wikipedia.org/wiki/Raw_image_format#Raw_filename_extensions_and_respective_camera_manufacturers_or_standard there are lots of different versions of it. Can you tell me which one is not working for you, and ideally also what error message is being logged on the backend?

@lrq3000
Copy link
Author

lrq3000 commented Sep 13, 2021

Hello, thank you very much for your fast reply!

I didn't self-host yet, I just tried to upload free CR2 images from this website into the ImageStore demo, and I got an error about the incorrect filetype, specifying that only jpg, jfif, png, etc. images are supported.

So is the support for raw files just an option I can toggle when I self-host? I didn't find any mention in the readme so that's why I also thought raw images were not supported, it would be awesome if they are! :D

@lrq3000
Copy link
Author

lrq3000 commented Sep 13, 2021

I just tried with my self-hosted instance, and here is the error I get:

On the website:

The following errors occured:
Unknown error happened and logged in tag Pao Macasu2 (2).CR2

In the console 's log:

backend_1 | Error: Input file has corrupt header: source input: Old-style JPEG compression support is not configured
backend_1 | source input: Old-style JPEG compression support is not configured
backend_1 | source input: Old-style JPEG compression support is not configured
backend_1 | source input: Old-style JPEG compression support is not configured
backend_1 | source input: Old-style JPEG compression support is not configured
backend_1 | tiff2vips: subsampled images not supported
backend_1 |

@gregordr
Copy link
Owner

gregordr commented Sep 13, 2021

Thanks! I made an issue on libvips about that, maybe if I give them the image that causes it they can add support for it. Unfortunately all alternatives that do support CR2 are quite slow, so I'm not sure what the best solution would be if libvips won't add support for this kind of RAW file.

libvips/libvips#2435

@gregordr
Copy link
Owner

gregordr commented Sep 13, 2021

Looks like they won't fix this (And I understand them).

Also, there is the issue that browsers don't work with all kinds of RAW files. As such, even if I fixed the issue above, the file couldn't be viewed, only downloaded. Converting it into a JPG before processing/storing it would be possible, but I feel like the user might be thinking that their file will stay a RAW file and try to retrieve it as one at a later point, so this solution is also not ideal.

I'm not really sure what the best course of action is here unfortunately. However, at least files with the .raw extension seem to work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants