-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JsonSchema.Net dependency #5
Comments
Thanks for the report. Nothing has changed in that area of code. I'll have to investigate.
Since this is a 0.x (alpha/beta?) version, it's not technically governed by SemVer. I believe the common practice, and the one that I follow, is that for 0.x versions, the numbers shift down one. So for 0.2.x, the 2 is treated as "major" and there's just not a patch version. A breaking change would bump to 0.3.0. |
Yeah, it looks like the hack was lost with the refactor to move the schema scanning to |
@laurynasr that was a strange one to track down. I ended up also supporting Native AOT with this release, and I found a problem in JsonPointer.Net's package where it seemed to be missing two methods. Not sure how that hasn't come up elsewhere since JsonSchema.Net is DEFINITELY using those methods. Anyway, the new version should work for you. |
I tried updating Graeae to use current version of JsonSchema.Net in my fork but hit a brick wall when trying to make the tests run. Apparently the previous hack to register draft4 as one of the supported meta-schemas no longer works and I can't figure out a way how to do that in the current version of JsonSchema.Net.
Also, this kind of change probably deserves a major version bump, but as the current major version is still 0 -- should it become 1.0.0 or 0.3.0?
Any guidance would be very appreciated.
Thanks
The text was updated successfully, but these errors were encountered: