Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When ready, reference 3rd-party Javascript code from remote location #10

Open
gregvonkuster opened this issue Oct 30, 2015 · 2 comments

Comments

@gregvonkuster
Copy link
Owner

The following are currently referenced locally, and should be referenced from their remote source. VTKLoader.js will need to be submitted to mr. door when we're ready.

    ${h.javascript_link( app_root + 'dat.gui.min.js' )}
    ${h.javascript_link( app_root + 'three.min.js' )}
    ${h.javascript_link( app_root + 'Detector.js' )}
    ${h.javascript_link( app_root + 'Lut.js' )}
    ${h.javascript_link( app_root + 'OrbitControls.js' )}
    ${h.javascript_link( app_root + 'PLYLoader.js' )}
    ${h.javascript_link( app_root + 'VTKLoader.js' )}
@pletzer
Copy link
Contributor

pletzer commented Nov 27, 2015

VTKLoader was commited so can use remote version.
I don't think PLYLoader was ever modified so should be able to use remote version.
Ditto for OrbitsControls.js for Detector.js data.gui.js and three.min.js.
Lut.js is no longer used.

@pletzer
Copy link
Contributor

pletzer commented Jan 7, 2016

@gregvonkuster Should be able to use VTKLoader.js from devel branch of three.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants