Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[typemap] Handle duplicates of generic types properly
Fixes: dotnet#4809 Context: 7117414 Context: a017561 Part of the a017561 commit dealt with mappings from certain Java types which point to the same Managed type by making sure that they all refer to the same type definition and managed type name. However, in doing so it failed to synchronize the property which indicates that we are dealing with an interface or generic type, in which case such a type should be ignored by the type mapping code in the runtime. In this particular case, the issue was with the `ArrayAdapter` type which has both a generic and non-generic definitions and it so happens that the *first* type in `Mono.Android` assembly is the generic one, thus it, and its duplicate, should be ignored but due to the failure to synchronize the `SkipInJavaToManaged` property, the second instance of the type was not skipped on the runtime, resulting in the following exception: System.MemberAccessException: Cannot create an instance of Android.Widget.ArrayAdapter`1[T] because Type.ContainsGenericParameters is true. at System.Reflection.RuntimeConstructorInfo.DoInvoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00054] in <d772a4bbe86c4dc5b425d8ca91786b91>:0 at System.Reflection.RuntimeConstructorInfo.Invoke (System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <d772a4bbe86c4dc5b425d8ca91786b91>:0 at System.Reflection.ConstructorInfo.Invoke (System.Object[] parameters) [0x00000] in <d772a4bbe86c4dc5b425d8ca91786b91>:0 at Java.Interop.TypeManager.CreateProxy (System.Type type, System.IntPtr handle, Android.Runtime.JniHandleOwnership transfer) [0x0001b] in <43cddc76fe22432dbdbcea2397b6fcd7>:0 at Java.Interop.TypeManager.CreateInstance (System.IntPtr handle, Android.Runtime.JniHandleOwnership transfer, System.Type targetType) [0x00111] in <43cddc76fe22432dbdbcea2397b6fcd7>:0 at Java.Lang.Object.GetObject (System.IntPtr handle, Android.Runtime.JniHandleOwnership transfer, System.Type type) [0x00023] in <43cddc76fe22432dbdbcea2397b6fcd7>:0 at Java.Lang.Object._GetObject[T] (System.IntPtr handle, Android.Runtime.JniHandleOwnership transfer) [0x00017] in <43cddc76fe22432dbdbcea2397b6fcd7>:0 at Java.Lang.Object.GetObject[T] (System.IntPtr handle, Android.Runtime.JniHandleOwnership transfer) [0x00000] in <43cddc76fe22432dbdbcea2397b6fcd7>:0 at Android.Widget.ArrayAdapter.CreateFromResource (Android.Content.Context context, System.Int32 textArrayResId, System.Int32 textViewResId) [0x0006d] in <43cddc76fe22432dbdbcea2397b6fcd7>:0 at AndroidApp1.MainActivity.OnCreate (Android.OS.Bundle savedInstanceState) [0x00031] in <51ce4ed05744482eb8a8079a399a17d2>:0 at Android.App.Activity.n_OnCreate_Landroid_os_Bundle_ (System.IntPtr jnienv, System.IntPtr native__this, System.IntPtr native_savedInstanceState) [0x0000f] in <43cddc76fe22432dbdbcea2397b6fcd7>:0 at (wrapper dynamic-method) Android.Runtime.DynamicMethodNameCounter.3(intptr,intptr,intptr) This commit adds synchronization of the `SkipInJavaToManaged` property which results in the sample attached to the GitHub issue to work properly. Note: for some weird reason the error occurred *only* with the *Release* build of `Mono.Android.dll` and *only* in the framework v9.0 (that is API28) - if the app targetted any other API it would not fail. I can't see why this would be so since the relevant code was very similar between v9.0 and other frameworks and it was *identical* in case of the *Debug* build of the v9.0 framework.
- Loading branch information