Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Bitcoin's key.cpp and pubkey.cpp code #2482

Closed
barton2526 opened this issue Apr 5, 2022 · 0 comments · Fixed by #2492
Closed

Port Bitcoin's key.cpp and pubkey.cpp code #2482

barton2526 opened this issue Apr 5, 2022 · 0 comments · Fixed by #2492
Assignees
Milestone

Comments

@barton2526
Copy link
Member

barton2526 commented Apr 5, 2022

While investigating bitcoin/bitcoin#16878 I found that our CKey code differs significantly from upstream's, particularly in the Set and Check methods (we do not have these at all). This leads to upsteam's file pubkey.cpp, which we do not have either. It was created here: bitcoin/bitcoin#5162.

Many of these differences date to 2013 or 2014, which should be before our split from upstream, but could be vestigal Black/Peercoin code. For future porting and security, we should strive to bring our key code in line with Bitcoin.

@div72 div72 self-assigned this Apr 5, 2022
@jamescowens jamescowens added this to the Kermit's Mom milestone Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants