You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While investigating bitcoin/bitcoin#16878 I found that our CKey code differs significantly from upstream's, particularly in the Set and Check methods (we do not have these at all). This leads to upsteam's file pubkey.cpp, which we do not have either. It was created here: bitcoin/bitcoin#5162.
Many of these differences date to 2013 or 2014, which should be before our split from upstream, but could be vestigal Black/Peercoin code. For future porting and security, we should strive to bring our key code in line with Bitcoin.
The text was updated successfully, but these errors were encountered:
While investigating bitcoin/bitcoin#16878 I found that our
CKey
code differs significantly from upstream's, particularly in theSet
andCheck
methods (we do not have these at all). This leads to upsteam's filepubkey.cpp
, which we do not have either. It was created here: bitcoin/bitcoin#5162.Many of these differences date to 2013 or 2014, which should be before our split from upstream, but could be vestigal Black/Peercoin code. For future porting and security, we should strive to bring our key code in line with Bitcoin.
The text was updated successfully, but these errors were encountered: