Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename debug commands to be more relevent and understandable. #879

Closed
ShmoogleOsukami opened this issue Jan 27, 2018 · 6 comments
Closed
Assignees
Milestone

Comments

@ShmoogleOsukami
Copy link
Member

Currently we have debug, debug2, debug3, debug10 and debugnew.

Debug is fine as is I think.

debug2 could be renamed debugStaker as It seems to output stuff related to staking blocks.

debug3 seems to output a lot of getblocks things. Probably debugIO, logging blockchain reads and stuff?

debug10 could be renamed to debugnetwork as its outputs a lot of network related stuff, pings and what not.

debugnew does not actually exist.

@iFoggz
Copy link
Member

iFoggz commented Jan 27, 2018

its debugnet* btw and is used in main.cpp, net.h , thou other network parts should be moved to it. I had future plans to change and reorganize some of the debugs as they cross over into other areas and not as sorted as should be.

@tomasbrod
Copy link
Member

@denravonska
Copy link
Member

I totally agree with this and thought the very same thing today. Debug flags should affect their respective component.

@denravonska denravonska added this to the Denise milestone Jan 8, 2019
@tomasbrod
Copy link
Member

The new logging framework allows logging by facility and the filtering -debug=facility.

@jamescowens jamescowens modified the milestones: Denise, Elizabeth Mar 15, 2019
@jamescowens jamescowens modified the milestones: Elizabeth, Fern Jul 6, 2019
@jamescowens jamescowens modified the milestones: Fern, Gladys Aug 3, 2019
@jamescowens
Copy link
Member

Yes, @tomasbrod is exactly right. Categories were implemented when I ported the Bitcoin logger. We just have to retire out the old debug stuff. We will do this post Fern in a leisure update, probably Gladys, because doing it now due to the pervasiveness of the debugs will screw up merges from other branches.

@jamescowens jamescowens self-assigned this Feb 16, 2020
@jamescowens
Copy link
Member

Completed with #1699.

@jamescowens jamescowens modified the milestones: Gladys, Fern Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants