Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: webclient: Cache summary/plot data #851

Open
amikryukov opened this issue Dec 29, 2017 · 0 comments
Open

Improvement: webclient: Cache summary/plot data #851

amikryukov opened this issue Dec 29, 2017 · 0 comments

Comments

@amikryukov
Copy link
Contributor

Not an Issue, but an improvement

Problem

Currently, web client re-read all data from database if you click on metric/plot several times.
The same happens, when you choose many sessions and many plots, and afterward, decide to remove one session from the view. It leads to all data to be fetched from DB one more time.

Implementation Details

Sessions changed:
SessionSelectChangeHandler calls #updateControlTree every time session is changed which leads to all Metric/Plot panels to be cleared, and all checked metrics/plots to be downloaded.
Almost the same happens when you check/uncheck plot for particular metric in DetailsNodeHandler

Technical Details

Inside Trends.java web client already store the plots, and summary metrics, which are downloaded and should be shown.

public class Trends ... {
  ...
  private HashMap<MetricNode, SummaryIntegratedDto> chosenMetrics = new HashMap<MetricNode, SummaryIntegratedDto>();
  private Map<MetricNode, PlotIntegratedDto> chosenPlots = new HashMap<MetricNode, PlotIntegratedDto>();
  ...

But by design, plot/metric name (MetricNameDto) has a link to session ids which are chosen (via TaskDataDto).

That is why it should be designed before an implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant