Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add props for all grid events #12

Open
scamden opened this issue Jan 18, 2018 · 5 comments
Open

add props for all grid events #12

scamden opened this issue Jan 18, 2018 · 5 comments

Comments

@scamden
Copy link
Member

scamden commented Jan 18, 2018

aka on-grid-cell-scroll etc

@jontg
Copy link
Contributor

jontg commented Mar 15, 2018

@scamden all of them? Would you prefer to be passed a dictionary prop, like...

{
  on-grid-cell-scroll: () => { console.log('why not?') },
   ...

or have each event be handled as a separate prop handler?

Also where do you handle/fire scroll events?

@jontg
Copy link
Contributor

jontg commented Mar 15, 2018

Also, are these the only events fired? I was expecting to see some scrolling events in here...

@scamden
Copy link
Member Author

scamden commented Mar 15, 2018

the standard way react does events is with separate props so i was thinking it best to just mirror that. it's not too hard anyway just need to get to it.

and no those are not the only events. try looking at the event-loop/index.ts file in the next branch (you should always be looking at the next branch for the code you guys are currently running)

@scamden
Copy link
Member Author

scamden commented Mar 15, 2018

btw @jontg i mentioned to alex but for now the workaround to this is to use a ref to get the grid instance, and do grid.eventLoop.bind('grid-cell-scroll', handler)

@jontg
Copy link
Contributor

jontg commented Mar 16, 2018

Aha, yeah I noticed that next in this adapter is behind by like 80 commits, and must've gotten confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants