Trying to force Sonar to re-analyze DTOs and go under coverage limit

Tristan-WorkGH · Tristan-WorkGH · commit b0544453493a · 2023-07-12T14:01:14.000+02:00
Signed-off-by: Tristan Chuine &lt;tristan.chuine_externe@rte-france.com&gt;

Try to go under 50% coverage limit in Sonar

Signed-off-by: Tristan Chuine &lt;tristan.chuine_externe@rte-france.com&gt;

tmp

Signed-off-by: Tristan Chuine &lt;tristan.chuine_externe@rte-france.com&gt;

tmp

Signed-off-by: Tristan Chuine &lt;tristan.chuine_externe@rte-france.com&gt;

tmp cancel fields

Signed-off-by: Tristan Chuine &lt;tristan.chuine_externe@rte-france.com&gt;
diff --git a/src/main/java/org/gridsuite/modification/server/dto/BasicEquipmentModificationInfos.java b/src/main/java/org/gridsuite/modification/server/dto/BasicEquipmentModificationInfos.java
@@ -7,10 +7,7 @@
 package org.gridsuite.modification.server.dto;
 
 import io.swagger.v3.oas.annotations.media.Schema;
-import lombok.Getter;
-import lombok.NoArgsConstructor;
-import lombok.Setter;
-import lombok.ToString;
+import lombok.*;
 import lombok.experimental.SuperBuilder;
 
 /**
@@ -21,6 +18,7 @@
 @Getter
 @Setter
 @ToString(callSuper = true)
+@EqualsAndHashCode
 @Schema(description = "Basic equipment modification")
 public class BasicEquipmentModificationInfos extends EquipmentModificationInfos {
     @Schema(description = "Equipment name modification")
diff --git a/src/main/java/org/gridsuite/modification/server/dto/BranchCreationInfos.java b/src/main/java/org/gridsuite/modification/server/dto/BranchCreationInfos.java
@@ -8,10 +8,7 @@
 
 import com.powsybl.iidm.network.extensions.ConnectablePosition;
 import io.swagger.v3.oas.annotations.media.Schema;
-import lombok.Getter;
-import lombok.NoArgsConstructor;
-import lombok.Setter;
-import lombok.ToString;
+import lombok.*;
 import lombok.experimental.SuperBuilder;
 
 /**
@@ -22,6 +19,7 @@
 @Getter
 @Setter
 @ToString(callSuper = true)
+@EqualsAndHashCode
 @Schema(description = "Branch creation")
 public class BranchCreationInfos extends EquipmentCreationInfos {
 
diff --git a/src/main/java/org/gridsuite/modification/server/dto/BranchModificationInfos.java b/src/main/java/org/gridsuite/modification/server/dto/BranchModificationInfos.java
@@ -6,10 +6,7 @@
  */
 package org.gridsuite.modification.server.dto;
 import io.swagger.v3.oas.annotations.media.Schema;
-import lombok.Getter;
-import lombok.NoArgsConstructor;
-import lombok.Setter;
-import lombok.ToString;
+import lombok.*;
 import lombok.experimental.SuperBuilder;
 
 /**
@@ -20,6 +17,7 @@
 @Getter
 @Setter
 @ToString(callSuper = true)
+@EqualsAndHashCode
 @Schema(description = "Branch creation")
 public class BranchModificationInfos extends BasicEquipmentModificationInfos {
 
diff --git a/src/main/java/org/gridsuite/modification/server/dto/BranchStatusModificationInfos.java b/src/main/java/org/gridsuite/modification/server/dto/BranchStatusModificationInfos.java
@@ -10,10 +10,7 @@
 import com.powsybl.commons.reporter.Reporter;
 import com.powsybl.commons.reporter.ReporterModel;
 import io.swagger.v3.oas.annotations.media.Schema;
-import lombok.Getter;
-import lombok.NoArgsConstructor;
-import lombok.Setter;
-import lombok.ToString;
+import lombok.*;
 import lombok.experimental.SuperBuilder;
 import org.gridsuite.modification.server.NetworkModificationException;
 import org.gridsuite.modification.server.dto.annotation.ModificationErrorTypeName;
@@ -30,6 +27,7 @@
 @Getter
 @Setter
 @ToString(callSuper = true)
+@EqualsAndHashCode
 @Schema(description = "Branch status modification")
 @JsonTypeName("BRANCH_STATUS_MODIFICATION")
 @ModificationErrorTypeName("BRANCH_ACTION_ERROR")
diff --git a/src/main/java/org/gridsuite/modification/server/dto/BuildInfos.java b/src/main/java/org/gridsuite/modification/server/dto/BuildInfos.java
@@ -7,10 +7,7 @@
 package org.gridsuite.modification.server.dto;
 
 import io.swagger.v3.oas.annotations.media.Schema;
-import lombok.AllArgsConstructor;
-import lombok.Getter;
-import lombok.NoArgsConstructor;
-import lombok.Setter;
+import lombok.*;
 
 import java.util.ArrayList;
 import java.util.HashSet;
@@ -25,6 +22,8 @@
 @AllArgsConstructor
 @Getter
 @Setter
+@ToString
+@EqualsAndHashCode
 @Schema(description = "Build infos")
 public class BuildInfos {
     private String originVariantId;
diff --git a/src/main/java/org/gridsuite/modification/server/dto/BusbarConnectionCreationInfos.java b/src/main/java/org/gridsuite/modification/server/dto/BusbarConnectionCreationInfos.java
@@ -8,10 +8,7 @@
 
 import com.powsybl.iidm.network.SwitchKind;
 import io.swagger.v3.oas.annotations.media.Schema;
-import lombok.AllArgsConstructor;
-import lombok.Getter;
-import lombok.NoArgsConstructor;
-import lombok.Setter;
+import lombok.*;
 import lombok.experimental.SuperBuilder;
 
 /**
@@ -22,6 +19,8 @@
 @AllArgsConstructor
 @Getter
 @Setter
+@ToString
+@EqualsAndHashCode
 @Schema(description = "Voltage level bus bar sections connection creation")
 public class BusbarConnectionCreationInfos {
     @Schema(description = "one side of the connection")
diff --git a/src/main/java/org/gridsuite/modification/server/dto/BusbarSectionCreationInfos.java b/src/main/java/org/gridsuite/modification/server/dto/BusbarSectionCreationInfos.java
@@ -7,11 +7,7 @@
 package org.gridsuite.modification.server.dto;
 
 import io.swagger.v3.oas.annotations.media.Schema;
-import lombok.AllArgsConstructor;
-import lombok.Getter;
-import lombok.NoArgsConstructor;
-import lombok.Setter;
-import lombok.ToString;
+import lombok.*;
 import lombok.experimental.SuperBuilder;
 
 /**
@@ -23,6 +19,7 @@
 @AllArgsConstructor
 @Getter
 @Setter
+@EqualsAndHashCode
 @Schema(description = "Voltage level bus bar section creation")
 public class BusbarSectionCreationInfos {
     @Schema(description = "bus bar section id")
diff --git a/src/main/java/org/gridsuite/modification/server/dto/CouplingDeviceInfos.java b/src/main/java/org/gridsuite/modification/server/dto/CouplingDeviceInfos.java
@@ -7,10 +7,7 @@
 package org.gridsuite.modification.server.dto;
 
 import io.swagger.v3.oas.annotations.media.Schema;
-import lombok.AllArgsConstructor;
-import lombok.Getter;
-import lombok.NoArgsConstructor;
-import lombok.Setter;
+import lombok.*;
 import lombok.experimental.SuperBuilder;
 
 /**
@@ -21,6 +18,8 @@
 @AllArgsConstructor
 @Getter
 @Setter
+@ToString
+@EqualsAndHashCode
 @Schema(description = "Coupling device creation")
 public class CouplingDeviceInfos {
     @Schema(description = "bus bar section 1 id")
diff --git a/src/main/java/org/gridsuite/modification/server/dto/CurrentLimitsInfos.java b/src/main/java/org/gridsuite/modification/server/dto/CurrentLimitsInfos.java
@@ -7,10 +7,7 @@
 package org.gridsuite.modification.server.dto;
 
 import io.swagger.v3.oas.annotations.media.Schema;
-import lombok.Getter;
-import lombok.NoArgsConstructor;
-import lombok.Setter;
-import lombok.ToString;
+import lombok.*;
 import lombok.experimental.SuperBuilder;
 import org.gridsuite.modification.server.entities.equipment.creation.CurrentLimitsEntity;
 import org.gridsuite.modification.server.entities.equipment.creation.CurrentTemporaryLimitCreationEmbeddable;
@@ -26,6 +23,7 @@
 @Getter
 @Setter
 @ToString
+@EqualsAndHashCode
 @Schema(description = "Current Limits")
 public class CurrentLimitsInfos {
 
diff --git a/src/main/java/org/gridsuite/modification/server/dto/NetworkModificationResult.java b/src/main/java/org/gridsuite/modification/server/dto/NetworkModificationResult.java
@@ -9,6 +9,7 @@
 import io.swagger.v3.oas.annotations.media.Schema;
 import lombok.Builder;
 import lombok.Data;
+import lombok.RequiredArgsConstructor;
 import org.gridsuite.modification.server.impacts.SimpleElementImpact;
 
 import java.util.List;
@@ -23,17 +24,14 @@
 @Data
 @Schema(description = "Network modification result")
 public class NetworkModificationResult {
+    @RequiredArgsConstructor
     public enum ApplicationStatus {
         ALL_OK(0),
         WITH_WARNINGS(1),
         WITH_ERRORS(2);
 
         private final int severityLevel;
 
-        ApplicationStatus(int severityLevel) {
-            this.severityLevel = severityLevel;
-        }
-
         public ApplicationStatus max(ApplicationStatus other) {
             return severityLevel >= other.severityLevel ? this : other;
         }
diff --git a/src/main/java/org/gridsuite/modification/server/dto/VoltageLevelInfos.java b/src/main/java/org/gridsuite/modification/server/dto/VoltageLevelInfos.java
@@ -6,22 +6,19 @@
  */
 package org.gridsuite.modification.server.dto;
 
-import lombok.EqualsAndHashCode;
-import lombok.Getter;
-import lombok.NoArgsConstructor;
-import lombok.ToString;
+import lombok.*;
 import lombok.experimental.SuperBuilder;
 
 /**
  * @author Nicolas Noir <nicolas.noir at rte-france.com>
  */
 @SuperBuilder
 @NoArgsConstructor
+@AllArgsConstructor
 @Getter
 @ToString
 @EqualsAndHashCode
 public class VoltageLevelInfos {
-
     String id;
 
     String name;
diff --git a/src/main/java/org/gridsuite/modification/server/dto/catalog/AerialLineTypeInfos.java b/src/main/java/org/gridsuite/modification/server/dto/catalog/AerialLineTypeInfos.java
@@ -9,7 +9,6 @@
 import io.swagger.v3.oas.annotations.media.Schema;
 import lombok.*;
 import lombok.experimental.SuperBuilder;
-
 import org.gridsuite.modification.server.entities.catalog.AerialLineTypeEntity;
 
 /**
diff --git a/src/main/java/org/gridsuite/modification/server/dto/catalog/LineTypeInfos.java b/src/main/java/org/gridsuite/modification/server/dto/catalog/LineTypeInfos.java
@@ -25,10 +25,7 @@
 @AllArgsConstructor
 @SuperBuilder
 @EqualsAndHashCode
-@JsonTypeInfo(
-    use = JsonTypeInfo.Id.NAME,
-    property = "category"
-)
+@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "category")
 @JsonSubTypes({
     @JsonSubTypes.Type(value = AerialLineTypeInfos.class, name = "AERIAL"),
     @JsonSubTypes.Type(value = UndergroundLineTypeInfos.class, name = "UNDERGROUND"),
@@ -64,6 +61,6 @@ public class LineTypeInfos {
 
     @JsonIgnore
     public LineTypeEntity toEntity() {
-        throw new UnsupportedOperationException("TODO");
+        throw new UnsupportedOperationException("TODO"); //TODO
     }
 }
diff --git a/src/main/java/org/gridsuite/modification/server/dto/catalog/UndergroundLineTypeInfos.java b/src/main/java/org/gridsuite/modification/server/dto/catalog/UndergroundLineTypeInfos.java
@@ -9,7 +9,6 @@
 import io.swagger.v3.oas.annotations.media.Schema;
 import lombok.*;
 import lombok.experimental.SuperBuilder;
-
 import org.gridsuite.modification.server.entities.catalog.UndergroundLineTypeEntity;
 
 /**
diff --git a/src/main/java/org/gridsuite/modification/server/dto/elasticsearch/EquipmentInfos.java b/src/main/java/org/gridsuite/modification/server/dto/elasticsearch/EquipmentInfos.java
@@ -80,8 +80,8 @@ public static Set<VoltageLevelInfos> getVoltageLevels(@NonNull Identifiable<?> i
                     VoltageLevelInfos.builder().id(w3t.getTerminal(ThreeWindingsTransformer.Side.THREE).getVoltageLevel().getId()).name(w3t.getTerminal(ThreeWindingsTransformer.Side.THREE).getVoltageLevel().getNameOrId()).build()
                 )
                 .collect(Collectors.toSet());
+        } else {
+            throw NetworkModificationException.createEquipmentTypeUnknown(identifiable.getClass().getSimpleName());
         }
-
-        throw NetworkModificationException.createEquipmentTypeUnknown(identifiable.getClass().getSimpleName());
     }
 }
diff --git a/src/main/java/org/gridsuite/modification/server/dto/elasticsearch/TombstonedEquipmentInfos.java b/src/main/java/org/gridsuite/modification/server/dto/elasticsearch/TombstonedEquipmentInfos.java
@@ -15,12 +15,12 @@
 /**
  * @author Nicolas Noir <nicolas.noir at rte-france.com>
  */
-@SuperBuilder
 @NoArgsConstructor
 @Getter
 @Setter
 @ToString(callSuper = true)
 @EqualsAndHashCode(callSuper = true)
+@SuperBuilder
 @Document(indexName = "#{@environment.getProperty('powsybl-ws.elasticsearch.index.prefix')}tombstoned-equipments")
 @Setting(settingPath = "elasticsearch_settings.json")
 @TypeAlias(value = "TombstonedEquipmentInfos")
diff --git a/src/main/java/org/gridsuite/modification/server/entities/equipment/modification/attribute/BooleanModificationEmbedded.java b/src/main/java/org/gridsuite/modification/server/entities/equipment/modification/attribute/BooleanModificationEmbedded.java
@@ -19,12 +19,10 @@
 /**
  * @author Jacques Borsenberger <jacques.borsenberger at rte-france.com>
  */
-
 @EqualsAndHashCode
 @Getter
 @Embeddable
 public class BooleanModificationEmbedded implements IAttributeModificationEmbeddable<Boolean> {
-
     private Boolean value;
     @Enumerated(EnumType.STRING)
     private OperationType opType;
diff --git a/src/main/java/org/gridsuite/modification/server/entities/equipment/modification/attribute/DoubleModificationEmbedded.java b/src/main/java/org/gridsuite/modification/server/entities/equipment/modification/attribute/DoubleModificationEmbedded.java
@@ -19,12 +19,10 @@
 /**
  * @author Jacques Borsenberger <jacques.borsenberger at rte-france.com>
  */
-
 @Embeddable
 @EqualsAndHashCode
 @Getter
 public class DoubleModificationEmbedded implements IAttributeModificationEmbeddable<Double> {
-
     private Double value;
     @Enumerated(EnumType.STRING)
     private OperationType opType;
diff --git a/src/main/java/org/gridsuite/modification/server/entities/equipment/modification/attribute/EnumModificationEmbedded.java b/src/main/java/org/gridsuite/modification/server/entities/equipment/modification/attribute/EnumModificationEmbedded.java
@@ -19,12 +19,10 @@
 /**
  * @author Jacques Borsenberger <jacques.borsenberger at rte-france.com>
  */
-
 @Embeddable
 @EqualsAndHashCode
 @Getter
 public class EnumModificationEmbedded<T extends Enum<?>> implements IAttributeModificationEmbeddable<T> {
-
     @Enumerated(EnumType.STRING)
     private T value;
     @Enumerated(EnumType.STRING)
diff --git a/src/main/java/org/gridsuite/modification/server/entities/equipment/modification/attribute/FloatModificationEmbedded.java b/src/main/java/org/gridsuite/modification/server/entities/equipment/modification/attribute/FloatModificationEmbedded.java
@@ -18,11 +18,9 @@
 /**
  * @author Ayoub Labidi <ayoub.labidi at rte-france.com>
  */
-
 @Embeddable
 @Getter
 public class FloatModificationEmbedded implements IAttributeModificationEmbeddable<Float> {
-
     private Float value;
     @Enumerated(EnumType.STRING)
     private OperationType opType;
diff --git a/src/main/java/org/gridsuite/modification/server/entities/equipment/modification/attribute/IAttributeModificationEmbeddable.java b/src/main/java/org/gridsuite/modification/server/entities/equipment/modification/attribute/IAttributeModificationEmbeddable.java
@@ -13,7 +13,6 @@
 /**
  * @author Jacques Borsenberger <jacques.borsenberger at rte-france.com>
  */
-
 public interface IAttributeModificationEmbeddable<T> {
     T getValue();
 
diff --git a/src/main/java/org/gridsuite/modification/server/entities/equipment/modification/attribute/StringModificationEmbedded.java b/src/main/java/org/gridsuite/modification/server/entities/equipment/modification/attribute/StringModificationEmbedded.java
@@ -18,11 +18,9 @@
 /**
  * @author Ayoub Labidi <ayoub.labidi at rte-france.com>
  */
-
 @Embeddable
 @Getter
 public class StringModificationEmbedded implements IAttributeModificationEmbeddable<String> {
-
     private String value;
     @Enumerated(EnumType.STRING)
     private OperationType opType;
diff --git a/src/main/java/org/gridsuite/modification/server/impacts/SimpleElementImpact.java b/src/main/java/org/gridsuite/modification/server/impacts/SimpleElementImpact.java
@@ -31,6 +31,7 @@ public enum SimpleImpactType {
         DELETION
     }
 
+    /** The type of impact */
     private SimpleImpactType impactType;
 
     /** The impacted element ID */
