Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MERN Issues #90

Open
9 of 21 tasks
griffinsharp opened this issue Dec 2, 2019 · 3 comments
Open
9 of 21 tasks

MERN Issues #90

griffinsharp opened this issue Dec 2, 2019 · 3 comments

Comments

@griffinsharp
Copy link
Owner

griffinsharp commented Dec 2, 2019

Here are things we need to fix with our project before it is "complete" and we can get credit and show to recruiters. When you fix something, put an "X" in the box on the markdown.

From MERN progress scorecard comments directly:

1.) Game is a little buggy but pretty cool

  • Fix major game bugs (starting, controller, joining, etc.)
  • If you're navigating site or playing, and something breaks, WRITE IT DOWN and tell whoever implemented that feature about it so that they can address it. Don't let these things pile up!
  • Upon ending the game, the stats are not being calculated correctly. Unsure if they are displaying fine, but at the very least, they are being calculated wrong on the phaser side (Loser hit, winner hit, and time (needs to be parsed)).

2.) The start game process could be improved

  • Game doesn't load properly sometimes (websocket issue, I believe) but works on refresh
  • I think the QR code is a little confusing as well, we should work on the overall flow we want our user to take from the site loading, so them playing.

3.) CSS could be improved

  • Mobile responsive (doesn't have to look great, just be able to navigate on mobile
  • Fix dead links
  • Nav bar got messed up as we added stats and highscore
  • Style stats and highscore and any other pages that are lacking styling. Just get the layout looking decent (centered, nice font, etc.)
  • Css of leaderboard and highscore is terrible.

4.) Auth

  • Signing up automatically directs you to /profile, which does NOT exist. Please redirect it to the home page. It also doesn't automatically sign you in, it makes you log in again after account creation.

5.) We need directions. It's fine for us because we designed it, but image trying to play this not knowing anything about the game.

  • Add a simple "How To" page
  • Add more descriptive directions on each page.

6.) READ ME

  • Need to update it to production Read Me
  • We NEED to take advantage of gifs for this project. We could make a really awesome video gif showing how to play, as well as gifs of a simple fight, and navigation.
  • Should have at minimum:
    • Technologies Used (need more on Phaser.js and Websocket and why we used them)
    • Pictures and gifs
    • Code Snippets (probably again centered around websocket, phaser, and user auth)
    • Who worked on the project (with links to our github) and roughly what each person did,
      like Griffin (link) - game logic
    • Change name of repo and update heroku

Most other issues were not either "actively functional" and "pixel perfect," so keep that in mind as we look over the project.

@arrudaricardo
Copy link
Collaborator

I can deal with the game logic,
1#

@chanakyav
Copy link
Collaborator

I will work on #2

@griffinsharp
Copy link
Owner Author

I will try to fix auth #4. And i'll do #6, but that comes after everything is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants