Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--tblite ignores solvation (--alpb & --gbsa) #1015

Closed
TimoSommer opened this issue Apr 19, 2024 · 4 comments · Fixed by #1020
Closed

--tblite ignores solvation (--alpb & --gbsa) #1015

TimoSommer opened this issue Apr 19, 2024 · 4 comments · Fixed by #1020
Labels
documentation Improvements or additions to documentation

Comments

@TimoSommer
Copy link

Describe the bug
If I run an xtb calculation with the --tblite flag, it will ignore the --alpb and --gbsa flags. Whatever solvent I input, or if I don't specify it at all, always gives me the same energy out. If the --tblite flag is removed, the energies differ for each solvent, as you would expect.

To Reproduce
Steps to reproduce the behaviour:

  1. Input file for testing, but should work always: test.xyz.gz
  2. Run "xtb test.xyz --tblite". The final energy that I get is -133.722563075203 Eh
  3. Run "rm xtbrestart; xtb test.xyz --tblite --alpb water". The final energy that I get is exactly the same as above.

Expected behaviour
I would expect the energy to differ depending on the solvation model, just as without the --tblite specification.

Additional context
Versions:
MacOs 14.4.1
xtb 6.6.1

@TimoSommer TimoSommer added the unconfirmed This report has not yet been confirmed by the developers label Apr 19, 2024
@Albkat
Copy link
Member

Albkat commented Apr 19, 2024

Hello,
as of now, tblite does not have a fully functioning solvation implementation.
I would suggest addressing this in tblite repository.

@TimoSommer
Copy link
Author

Thanks for your opinion on this! I would suggest to add an error then if someone specifies --tblite together with a solvent, and also mentioning this in the documentation. This can become a little confusing otherwise if people are not aware of this limitation.

@Albkat Albkat added documentation Improvements or additions to documentation and removed unconfirmed This report has not yet been confirmed by the developers labels Apr 19, 2024
@Albkat
Copy link
Member

Albkat commented Apr 19, 2024

Yes, that sounds like a good idea.
Thank you.

@TimoSommer
Copy link
Author

Cool, thank you!

@Albkat Albkat linked a pull request Apr 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants