Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Add compatibility with Larastan #165

Open
YannickYayo opened this issue Feb 19, 2021 · 0 comments · May be fixed by #166
Open

[BUG] Add compatibility with Larastan #165

YannickYayo opened this issue Feb 19, 2021 · 0 comments · May be fixed by #166

Comments

@YannickYayo
Copy link

Hi, when using Larastan, we will have many errors due to the use of a custom Eloquent Builder.
Following this Upgrade Guide : , we have to use a phpdoc on the Grimzy\LaravelMysqlSpatial\Eloquent\Builder class to mark i as a generic Class.
YannickYayo added a commit to YannickYayo/laravel-mysql-spatial that referenced this issue Feb 19, 2021
@YannickYayo
feat: add compatibility to Larastan
4df056f 
*  Add compatibility to Larastan by marking the Grimzy\LaravelMysqlSpatial\Eloquent\Builder class as a generic class

(grimzy/issues/165)
@YannickYayo YannickYayo linked a pull request Feb 19, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add compatibility to Larastan YannickYayo/laravel-mysql-spatial
1 participant
@YannickYayo