-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error Handling and Image Description fixed seed problem #73
Comments
Thank you very much for the report - I’ll see what I can do to resolve the issues. Cheers! |
For issue 1, there's a parameter in Griptape to modify the I'll also add a Canceling a job is something that is on the list as well - as soon as it's in the framework, I'll add it! Will take a look at issue 2 now. |
btw - here's the link to the ticket asking for |
@shhlife this actually sounds like it's the Prompt Driver that is retrying -- not the Agent using Tools. This can be changed today by setting |
thanks @collindutter! I'll add that field! |
Thank you Jason and Colin. The max-subtasks feature would be very helpful.
The issue likely stems from reusing the same "PromptTask" with a fixed seed. This could also potentially occur with random seeds, as they're limited to 0-2048. When processing hundreds of images in batch, there's a chance of generating identical "random" numbers consecutively, leading to errors. maybe my workflow is not correct, I used this simple setup: https://we.tl/t-2XZlo1ADXq |
Thanks @vraagje - I'll check that out. In the meantime, I've pushed a fix for issue#2 to dev, just adding a few more items and running a few tests before pushing to main. |
Hmm - trying to replicate your issue and it doesn't appear to be happening to me. It could be that my fix for the other issue of the config getting re-evaluated resolved it? I'll push the fix to main shortly & then if you could try it, that'd be great. |
accidental fix :) . I try when pushed let me know |
Hey Jason, Just saw the fix you put out - my bad for not noticing earlier! Gave it a try and looks like both problems are sorted now. Great! |
Awesome, thanks! :) |
Issue 1: Limit Retries on Error or Add Cancel Option
Currently, when an error occurs, Grip attempts to retry the operation 10 times. During this process, the interface becomes unresponsive until all retry attempts are completed.
Suggestion:
Consider implementing one or both of these improvements:
Reduce the number of automatic retries from 10 to a lower number.
Add a feature to cancel the job during the retry process.
Issue 2: Inconsistent Behavior with Image Description Agent seed
I've noticed an inconsistency with the image description agent:
When the seed is set to a fixed value in the Anthropic configuration node, the image description agent still runs each time instead of just once as expected.
Expected: With a fixed seed, the image description agent should only run once and cache the output when the input image is not changed.
The text was updated successfully, but these errors were encountered: