Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Heading level 1 inside a Layer #3

Open
taysea opened this issue Aug 4, 2021 · 0 comments
Open

No Heading level 1 inside a Layer #3

taysea opened this issue Aug 4, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@taysea
Copy link
Collaborator

taysea commented Aug 4, 2021

Please describe what the rule should do:

Should mark if Heading Level 1 is used inside a Layer and should suggest using Heading level 2 instead.

What category of rule is this? (place an "X" next to just one item)

[x] Warns about a potential error (problem)
[ ] Suggests an alternate way of doing something (suggestion)
[ ] Other (please specify:)

Provide 2-3 code examples that this rule will warn about:

<Layer>
   <Heading level={1}>Layer title</Heading>
</Layer>

<Layer>
   <Heading>Layer 2 title</Heading> // level 1 is default
</Layer>

Why should this rule be included in eslint-plugin-grommet?

Accessibility best practices.

@taysea taysea added the enhancement New feature or request label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant