Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormField required includes aria-required="true" #39

Open
halocline opened this issue Dec 8, 2022 · 1 comment
Open

FormField required includes aria-required="true" #39

halocline opened this issue Dec 8, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@halocline
Copy link
Collaborator

halocline commented Dec 8, 2022

Please describe what the rule should do:

What category of rule is this? (place an "X" next to just one item)

[x] Warns about a potential error (problem)
[ ] Suggests an alternate way of doing something (suggestion)
[ ] Other (please specify:)

Provide 2-3 code examples that this rule will warn about:

<FormField
      htmlFor={id}
      name={name}
      label="Host Name"
      required
 >
 ...
 </FormField>

Why should this rule be included in eslint-plugin-grommet?

Ensuring proper aria attributes are applied. May be a nice enhancement to Grommet FormField?

@halocline halocline added the enhancement New feature or request label Dec 8, 2022
@jcfilben
Copy link
Collaborator

jcfilben commented Dec 8, 2022

Related to grommet/grommet#6524

@halocline halocline added the help wanted Extra attention is needed label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants